Re: [PATCH 4/6] regulator: core: remove `goto`s from resolve_supply()

From: Doug Anderson
Date: Mon Aug 21 2023 - 12:51:04 EST


Hi,

On Sat, Aug 19, 2023 at 3:46 PM Michał Mirosław <mirq-linux@xxxxxxxxxxxx> wrote:
>
> Since 14a71d509ac8 ("Fix lockdep warning resolving supplies") the `out`
> label is just `return ret;`. Inline it for easier reading.
>
> Signed-off-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx>
> ---
> drivers/regulator/core.c | 29 +++++++++++------------------
> 1 file changed, 11 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c

Please also remove the initialization of ret to 0 ("int ret = 0;") at
the start of the function. Then:

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>