Re: [PATCH v3 08/12] PM: EM: Introduce runtime modifiable table

From: Lukasz Luba
Date: Mon Aug 21 2023 - 11:25:18 EST




On 8/16/23 14:05, Dietmar Eggemann wrote:
On 21/07/2023 17:50, Lukasz Luba wrote:
This patch introduces the new feature: modifiable EM perf_state table.

nit pick: The first sentence doesn't add any information. I would skip it.

[...]

The runtime modifiable EM data is used by the Energy Aware Scheduler (EAS)
for the task placement. The EAS is the only user of the 'runtime
modifiable EM'.

The runtime modifiable EM is currently only used ...
The you can skip the next sentence: "The EAS is the only user ..."

All the other users (thermal, etc.) are still using the
default (basic) EM. This fact drove the design of this feature.

[...]


Thanks, I'll remove them in the next version.