Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file

From: Shenwei Wang
Date: Mon Aug 21 2023 - 09:22:57 EST




> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: Saturday, August 19, 2023 3:04 AM
> To: Shenwei Wang <shenwei.wang@xxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; Ulf Hansson <ulf.hansson@xxxxxxxxxx>; Liam Girdwood
> <lgirdwood@xxxxxxxxx>; Mark Brown <broonie@xxxxxxxxxx>;
> imx@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> dl-linux-imx <linux-imx@xxxxxxx>
> Subject: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report this
> email' button
>
>
> >>
> >> This needs to answer why we need this.
> >>
> >> It looks like just an abstraction layer to make regulators look like
> >> a power domain.
> >>
> >
> > Yes, it is a wrapper that allows using regulators as a power domain.
> > This removes the need to add regulator operating code in each consumer
> > device driver. As a power domain, the regulator will be managed
> > automatically by the device driver framework and PM subsystem.
> >
> > This is very useful when a device's power is controlled by a GPIO pin,
> > which currently requires using the fixed-regulator to achieve the same
> > purpose. However, the fixed-regulator approach may have to add code in the
> driver in order to use it.
>
> Why do you start discussion from zero ignoring all previous history of this
> patchset?
>

Thank you for providing the link. After reviewing the entire thread, I still don't understand how
to proceed. What is the conclusion regarding this commonly used use case but overlooked feature
in the upstream kernel?

Thanks,
Shenwei

> https://lore.kern/
> el.org%2Fall%2F20220609150851.23084-1-
> max.oss.09%40gmail.com%2F&data=05%7C01%7Cshenwei.wang%40nxp.com%
> 7C2cf40d23202c430302c908dba08add2e%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C0%7C0%7C638280290493921016%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
> 3000%7C%7C%7C&sdata=0O%2FIytE6YbJL26je7hoxEu0ayZYs07PBjfZkBDVaC1M
> %3D&reserved=0
>
> Best regards,
> Krzysztof