Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3

[Bryan O'Donoghue]

On 21/08/2023 10:53, Hans Verkuil wrote:
> Hi Bryan,
>
> On 14/08/2023 16:10, Bryan O'Donoghue wrote:
> > VC_MODE = 0 implies a two bit VC address.
> > VC_MODE = 1 is required for VCs with a larger address than two bits.
>
> This explains the second chunk in the patch below, but it doesn't explain
> why dt_id is now suddenly vc * 4 instead of vc.
>
> I don't feel comfortable merging this patch since I'm not sure if that
> dt_id change was perhaps an error.
>
> If the change IS correct, then please reply and provide a better commit
> log.

From memory that's a copy/paste from the original qcom code.

I'll verify that and repost a better commit log.

---
bod