Re: [PATCH v2 1/2] UML: hard-code the result of 'uname -s'

From: Masahiro Yamada
Date: Sat Aug 19 2023 - 20:31:21 EST


On Sun, Aug 20, 2023 at 6:15 AM Richard Weinberger <richard@xxxxxx> wrote:
>
> ----- Ursprüngliche Mail -----
> > Von: "masahiroy" <masahiroy@xxxxxxxxxx>
> > We rely on 'uname -s' returning 'Linux' because there are os-Linux/
> > directories, but no other os-*/.
> >
> > Supporting a non-Linux host is unlikely to happen.
> >
> > Let's hard-code 'Linux'.
>
> While I agree that a non-Linux version is unlikely I'd like to
> know why we can't keep the uname -s check?
> I guess to avoid unnecessary command execution?



Just because 'uname -s' is meaningless.

Just build 'Linux' ones irrespective of the host platform.
If it works, it works.
If not, it does not work.




--
Best Regards
Masahiro Yamada