Re: [PATCH v1 1/1] serial: core: Remove unused PORT_* definitions

[Greg Kroah-Hartman]

On Fri, Aug 18, 2023 at 02:12:29PM +0300, Andy Shevchenko wrote:
> For the last couple of years Linux kernel got rid of a few architectures
> and many platforms. Hence some PORT_* definitions in the serial_core.h
> become unused and redundant. Remove them for good.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  include/uapi/linux/serial_core.h | 43 ++------------------------------
>  1 file changed, 2 insertions(+), 41 deletions(-)
> 
> diff --git a/include/uapi/linux/serial_core.h b/include/uapi/linux/serial_core.h
> index 281fa286555c..c361570a334f 100644
> --- a/include/uapi/linux/serial_core.h
> +++ b/include/uapi/linux/serial_core.h
> @@ -28,7 +28,7 @@
>   */
>  #define PORT_NS16550A	14
>  #define PORT_XSCALE	15
> -#define PORT_RM9000	16	/* PMC-Sierra RM9xxx internal UART */
> +

I'm all for removing these defines, but are you sure they are not used
in any userspace code?  Ususally a debian code search is good enough
"proof" of this, did you do that?

thanks,

greg k-h