Re: [PATCH] ubifs: fix missing error code err

From: Zhihao Cheng
Date: Fri Aug 18 2023 - 22:30:07 EST


在 2023/8/18 17:18, Ferry Meng 写道:
Fix smatch warning:

fs/ubifs/journal.c:1610 ubifs_jnl_truncate() warn: missing error code
'err'

Signed-off-by: Ferry Meng <mengferry@xxxxxxxxxxxxxxxxx>


Reviewed-by: Zhihao Cheng <chengzhihao1@xxxxxxxxxx>

diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
index dc52ac0f4a34..ab837b73d4b9 100644
--- a/fs/ubifs/journal.c
+++ b/fs/ubifs/journal.c
@@ -1607,6 +1607,7 @@ int ubifs_jnl_truncate(struct ubifs_info *c, const struct inode *inode,
ubifs_err(c, "bad data node (block %u, inode %lu)",
blk, inode->i_ino);
ubifs_dump_node(c, dn, dn_size);
+ err = -EUCLEAN;
goto out_free;
}