Re: [PATCH 3/8] KVM: gmem: Fix kvm_gmem_issue_arch_invalidate()

From: Sean Christopherson
Date: Fri Aug 18 2023 - 18:34:56 EST


On Tue, Aug 15, 2023, isaku.yamahata@xxxxxxxxx wrote:
> From: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>
>
> __filemap_get_folio() can return error. Use IS_ERR_OR_NULL.
>
> Signed-off-by: Isaku Yamahata <isaku.yamahata@xxxxxxxxx>

*sigh*

(a) This patch is ordered incorrectly, it belongs after patch 6.

(b) Don't post broken patches with fixup in the same damn series.

This is not hard, these are basic rules of the road.

Sorry for being grumpy, but I spent way too much time figuring out what on earth
was going on, for something that should have required exactly _zero_ effort on
my end.