Re: [RFC PATCH v1 2/8] iommu/arm-smmu-v3: Perform invalidations over installed_smmus

From: Michael Shavit
Date: Thu Aug 17 2023 - 23:46:26 EST


On Fri, Aug 18, 2023 at 3:41 AM Robin Murphy <robin.murphy@xxxxxxx> wrote:
>
> On 2023-08-17 20:20, Jason Gunthorpe wrote:
> > It is certainly wrong to skip invalidations generated for any other
> > reason.
> >
> > From what I can tell SVA domains should have their CD table entry
> > programmed with "ASET=0" and normal paging domains should be
> > programmed with "ASET=1". This causes only the SVA domains to listen
> > to the BTM invalidations.
>
> Correct.
>
> Thanks,
> Robin.

Would it be fair to rename arm_smmu_tlb_inv_asid (or move into
arm-smmu-v3-sva) to make it explicit that it shouldn't be used outside
of SVA then? Or add a parameter such as skip_btm_capable_devices.