Re: [PATCH v8 3/5] iommufd: Add IOMMU_GET_HW_INFO

From: Nicolin Chen
Date: Thu Aug 17 2023 - 21:31:29 EST


On Thu, Aug 17, 2023 at 05:21:43PM -0700, Nicolin Chen wrote:
> On Thu, Aug 17, 2023 at 05:08:34PM -0700, Nicolin Chen wrote:
> > On Fri, Aug 18, 2023 at 12:04:29AM +0000, Liu, Yi L wrote:
> >
> > > > From: Nicolin Chen <nicolinc@xxxxxxxxxx>
> > > > Sent: Friday, August 18, 2023 5:08 AM
> > > >
> > > > Looks like Yi's latest code has not addressed these comments.
> > >
> > > Yeah. Not yet. In progress to incorporate them. 😊
> >
> > I fixed them all in my local tree. I'm finalizing with alloc_user.
> > Let me send my branch after that, and you can edit upon :)
>
> https://github.com/nicolinc/iommufd/tree/wip/iommufd_alloc_user-08172023-nic
> Attached two sets of git-diff for the updates that I made to the
> two series. Note that I didn't make any change to the VT-d patch.

> } else {
> cmd->out_data_type = IOMMU_HW_INFO_TYPE_NONE;
> data_len = 0;
> - data = NULL;

Reverted this one and removed its initialization in my remote
branch, following Jason's latest email.

Thanks
Nic