Re: [PATCH 2/4] linux/array_size.h: Add ARRAY_SIZE_OF_FIELD()

From: Andy Shevchenko
Date: Thu Aug 17 2023 - 17:31:22 EST


On Thu, Aug 17, 2023 at 11:34 PM Alejandro Colomar <alx@xxxxxxxxxx> wrote:
> On 2023-08-17 16:33, Lucas Segarra Fernandez wrote:

...

> Some comment about the name:
>
> ARRAY_SIZE() is rather ambiguous, as there's array_size()[1], which means the
> number of bytes needed to represent the array. I suggest a name based on
>
> - _Lengthof() It has been proposed to ISO C to get the number of elements
> of an array:
> <https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2529.pdf>.
>
> - sizeof_field() The kernel macro for the size of a struct member
>
> So, how about lengthof_field()?

TBH I do not understand the motivation of making this kind of
confusion and inconsistency. Are you suggesting renaming ARRAY_SIZE()
to begin with? If so, it's definitely out of the scope of this series.

--
With Best Regards,
Andy Shevchenko