Re: [PATCH 3/3] arm64: dts: rockchip: Add Orange Pi 5

[Ondřej Jirman]

On Thu, Aug 17, 2023 at 05:30:04PM +0200, megi xff wrote:
> 
> On Thu, Aug 17, 2023 at 05:57:55PM +0300, Muhammed Efe Cetin wrote:
> > 
> > Hi, Ondřej
> > 
> > On 17.08.2023 16:57, Ondřej Jirman wrote:
> > > Hi Muhammed,
> > > 
> > >>>> [...]
> > >>>
> > >>>> +	vcc_1v1_nldo_s3: vcc-1v1-nldo-s3-regulator {
> > >>>> +		compatible = "regulator-fixed";
> > >>>> +		regulator-name = "vcc_1v1_nldo_s3";
> > >>>> +		regulator-always-on;
> > >>>> +		regulator-boot-on;
> > >>>> +		regulator-min-microvolt = <1100000>;
> > >>>> +		regulator-max-microvolt = <1100000>;
> > >>>> +		vin-supply = <&vcc5v0_sys>;
> > >>>> +	};
> > >>>
> > >>> There's no such regulator on the board.
> > >>
> > >> It's connected to PMIC https://i.imgur.com/sVJdC5K.png
> > > 
> > > It's not a separate fixed regulator. It's a PMIC output from buck6 https://megous.com/dl/tmp/8630fa17407c75b9.png
> > > 
> > 
> > I think it should be fixed regulator. It's used as vcc13-supply and
> > vcc14-supply regulator on PMIC and it's same as other rk3588 boards.
> 
> Yes, BUCK6 output is input to some LDOs. If you make this a regulator-fixed,
> BUCK6 will not get enabled when those LDOs are enabled, and the LDOs will not
> work because they'll lack input power.
> 
> Your regulator-fixed does nothing to enable BUCK6 which is where vcc_1v1_nldo_s3
> power rail is connected.
> 
> It only works for you now, because dcdc-reg6 is marked as regulator-always-on,
> so it's already enabled when you need those dependent LDOs.

And if other boards have this same HW setup and user separate DT node with
regulator-fixed for this, they're broken, too.

regards,
	o.

> regards,
> 	o.
> 
> > > So this is VDD2_DDR_S3. If you want to keep the alias, just add extra alias to
> > > dcdc-reg6 like this:
> > > 
> > > 		...
> > > 	vcc_1v1_nldo_s3: vdd2_ddr_s3: dcdc-reg6 {
> > > 		...
> > > 
> > >>>