Re: [PATCH v3 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver

From: kernel test robot
Date: Thu Aug 17 2023 - 11:26:34 EST


Hi Manikandan,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on lee-mfd/for-mfd-next lee-leds/for-leds-next lee-mfd/for-mfd-fixes linus/master v6.5-rc6 next-20230817]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Manikandan-Muralidharan/mfd-atmel-hlcdc-Add-compatible-for-sam9x75-XLCD-controller/20230817-172003
base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link: https://lore.kernel.org/r/20230817091250.225512-6-manikandan.m%40microchip.com
patch subject: [PATCH v3 5/8] drm: atmel_hlcdc: Add support for XLCDC in atmel LCD driver
config: arm-randconfig-r046-20230817 (https://download.01.org/0day-ci/archive/20230817/202308172303.AgUIhGKY-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172303.AgUIhGKY-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308172303.AgUIhGKY-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:1013:6: warning: no previous prototype for function 'hlcdc_irq_dbg' [-Wmissing-prototypes]
1013 | void hlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
| ^
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:1013:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
1013 | void hlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
| ^
| static
>> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:1029:6: warning: no previous prototype for function 'xlcdc_irq_dbg' [-Wmissing-prototypes]
1029 | void xlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
| ^
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c:1029:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
1029 | void xlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
| ^
| static
2 warnings generated.


vim +/hlcdc_irq_dbg +1013 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c

1012
> 1013 void hlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
1014 const struct atmel_hlcdc_layer_desc *desc)
1015 {
1016 u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_HLCDC_LAYER_ISR);
1017
1018 /*
1019 * There's not much we can do in case of overrun except informing
1020 * the user. However, we are in interrupt context here, hence the
1021 * use of dev_dbg().
1022 */
1023 if (isr &
1024 (ATMEL_HLCDC_LAYER_OVR_IRQ(0) | ATMEL_HLCDC_LAYER_OVR_IRQ(1) |
1025 ATMEL_HLCDC_LAYER_OVR_IRQ(2)))
1026 pr_warn("%s: overrun on plane %s\n", __func__, desc->name);
1027 }
1028
> 1029 void xlcdc_irq_dbg(struct atmel_hlcdc_plane *plane,
1030 const struct atmel_hlcdc_layer_desc *desc)
1031 {
1032 u32 isr = atmel_hlcdc_layer_read_reg(&plane->layer, ATMEL_XLCDC_LAYER_ISR);
1033
1034 /*
1035 * There's not much we can do in case of overrun except informing
1036 * the user. However, we are in interrupt context here, hence the
1037 * use of dev_dbg().
1038 */
1039 if (isr &
1040 (ATMEL_XLCDC_LAYER_OVR_IRQ(0) | ATMEL_XLCDC_LAYER_OVR_IRQ(1) |
1041 ATMEL_XLCDC_LAYER_OVR_IRQ(2)))
1042 pr_warn("%s: overrun on plane %s\n", __func__, desc->name);
1043 }
1044

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki