Re: [PATCH] media: vb2: frame_vector.c: replace WARN_ONCE with a comment

From: Hans Verkuil
Date: Thu Aug 17 2023 - 11:03:28 EST


On 17/08/2023 16:56, Linus Torvalds wrote:
> On Thu, 17 Aug 2023 at 12:41, Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote:
>>
>> There are no reports of WARN_ONCE being issued for actual VM_IO cases, so
>> just drop it and instead add a note to the comment before the function.
>
> Ack. That was meant to catch any (unlikely) strange users, but yeah,
> it can obviously be triggered by "intentional" strange users, ie
> syzbot and friends, so since there seems to be no sign of actual
> real-world use, just removing the WARN_ONCE() is the right thing to
> do.
>
> I'm assuming I'll get this eventually through the regular media pulls?
>
> Linus

Yes, that's the plan.

Regards,

Hans