Re: [PATCH v1 1/1] fs/affs: Rename local toupper() to fn() to avoid confusion

From: David Sterba
Date: Thu Aug 17 2023 - 09:54:00 EST


On Thu, Aug 17, 2023 at 03:12:17PM +0300, Andy Shevchenko wrote:
> A compiler may see the collision with the toupper() defined in ctype.h:
>
> fs/affs/namei.c:159:19: warning: unused variable 'toupper' [-Wunused-variable]
> 159 | toupper_t toupper = affs_get_toupper(sb);
>
> To prevent this from happening, rename toupper local variable to fn.
>
> Initially this had been introduced by 24579a881513 ("v2.4.3.5 -> v2.4.3.6")
> in the history.git by history group.
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

Added to affs tree, thanks.