Re: [PATCH v2 2/2] gpio: mlxbf3: Support add_pin_ranges()

From: kernel test robot
Date: Thu Aug 17 2023 - 07:01:33 EST


Hi Asmaa,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linusw-pinctrl/for-next brgl/gpio/for-next linus/master v6.5-rc6 next-20230816]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Asmaa-Mnebhi/pinctrl-mlxbf3-Remove-gpio_disable_free/20230816-234711
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
patch link: https://lore.kernel.org/r/20230816154442.8417-3-asmaa%40nvidia.com
patch subject: [PATCH v2 2/2] gpio: mlxbf3: Support add_pin_ranges()
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230817/202308171834.7ikT2B4p-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230817/202308171834.7ikT2B4p-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308171834.7ikT2B4p-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

drivers/gpio/gpio-mlxbf3.c: In function 'mlxbf3_gpio_add_pin_ranges':
>> drivers/gpio/gpio-mlxbf3.c:164:13: warning: unused variable 'ret' [-Wunused-variable]
164 | int ret;
| ^~~


vim +/ret +164 drivers/gpio/gpio-mlxbf3.c

160
161 static int mlxbf3_gpio_add_pin_ranges(struct gpio_chip *chip)
162 {
163 unsigned int id = 0;
> 164 int ret;
165
166 if (chip->ngpio % MLXBF3_GPIO_MAX_PINS_PER_BLOCK)
167 id = 1;
168
169 return gpiochip_add_pin_range(chip, "MLNXBF34:00",
170 chip->base, id * MLXBF3_GPIO_MAX_PINS_PER_BLOCK,
171 chip->ngpio);
172 }
173

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki