Re: [PATCH net-next 3/6] net/smc: support smc v2.x features validate

From: Guangguan Wang
Date: Thu Aug 17 2023 - 05:26:58 EST




On 2023/8/17 14:42, Jan Karcher wrote:
> Hi Guangguan Wang,
>
> minor renaming.
>
> On 16/08/2023 10:33, Guangguan Wang wrote:
>> Support SMC v2.x features validate for SMC v2.1. This is the frame
>> code for SMC v2.x features validate, and will take effects only when
>> the negotiated release version is v2.1 or later.
>>
>> For Server, v2.x features' validation should be done in smc_clc_srv_
>> v2x_features_validate when receiving v2.1 or later CLC Proposal Message,
>> such as max conns, max links negotiation, the decision of the final
>> value of max conns and max links should be made in this function.
>> And final check for server when receiving v2.1 or later CLC Confirm
>> Message should be done in smc_clc_v2x_features_confirm_check.
>>
>> For client, v2.x features' validation should be done in smc_clc_cli_
>> v2x_features_validate when receiving v2.1 or later CLC Accept Message,
>
> please use either clnt or client for the function. I know we have some functions with cli in them but they need to be cleaned up down the road.
>
> Thank you.
> - Jan
>

Get it, Thanks.