Re: [PATCH RESEND] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock

From: Chengfeng Ye
Date: Thu Aug 17 2023 - 03:49:31 EST


> So you did not use lockdep or is the code path so unlikely that nobody
> stumbled upon it before?

I think so, the lock acquisition inside the interrupt is guarded by an
"unlikely"
if-branch condition inside fnic_send_frame(), so it happens that no one has
encountered the problem so far by using lockdep.


> Fixes: 794d98e77f590 ("[SCSI] libfcoe: retry rejected FLOGI to another FCF if possible")

Just sent v2 patch to add the fixes tag


Thanks for the review,
Chengfeng