Re: [PATCH] i2c: Make I2C_ATR invisible

[Luca Ceresoli]

Hi Geert,

On Tue, 15 Aug 2023 17:29:11 +0200
Geert Uytterhoeven <geert+renesas@xxxxxxxxx> wrote:

> I2C Address Translator (ATR) support is not a stand-alone driver, but a
> library.  All of its users select I2C_ATR.  Hence there is no need for
> the user to enable this symbol manually, except when compile-testing.
> 
> Fixes: a076a860acae77bb ("media: i2c: add I2C Address Translator (ATR) support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> Do we care yet about out-of-tree drivers that need this functionality?
> ---
>  drivers/i2c/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index c6d1a345ea6d8aee..9388823bb0bb960c 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -72,7 +72,7 @@ config I2C_MUX
>  source "drivers/i2c/muxes/Kconfig"
>  
>  config I2C_ATR
> -	tristate "I2C Address Translator (ATR) support"
> +	tristate "I2C Address Translator (ATR) support" if COMPILE_TEST

Either as-is, or with an anonymous tristate:

Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>

Luca

-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com