RE: [PATCH v8 2/5] iommu: Add new iommu op to get iommu hardware information

From: Tian, Kevin
Date: Thu Aug 17 2023 - 03:25:30 EST


> From: Liu, Yi L <yi.l.liu@xxxxxxxxx>
> Sent: Wednesday, August 16, 2023 8:14 PM
>
> Different IOMMU hardware would have different hardware information. So
> the
> information reported differs as well. To let the external user understand
> the difference. enum iommu_hw_info_type is defined. For the iommu

s/difference. enum/difference, enum/

> + * @hw_info: IOMMU hardware information. The type of the returned data
> is
> + * marked by the output type of this op. Type is one of
> + * enum iommu_hw_info_type defined in
> include/uapi/linux/iommufd.h.
> + * The drivers that support this op should define a unique type
> + * in include/uapi/linux/iommufd.h. The data buffer returned by this
> + * op is allocated in the IOMMU driver and the caller should free it
> + * after use. Return the data buffer if success, or ERR_PTR on
> + * failure.

simplified as:

@hw_info: report iommu hardware information. The data buffer returned by
this op is allocated in the iommu driver and freed by the caller
after use. The information type is one of enum iommu_hw_info_type
defined in include/uapi/linux/iommufd.h.

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>