Re: [PATCH v6 06/10] iommu/arm-smmu-v3: Move CD table to arm_smmu_master

From: Nicolin Chen
Date: Wed Aug 16 2023 - 21:03:01 EST


On Wed, Aug 16, 2023 at 09:18:46PM +0800, Michael Shavit wrote:

> @@ -2463,16 +2448,43 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev)
> if (smmu_domain->stage != ARM_SMMU_DOMAIN_BYPASS)
> master->ats_enabled = arm_smmu_ats_supported(master);
>
> - arm_smmu_install_ste_for_dev(master);
>
> spin_lock_irqsave(&smmu_domain->devices_lock, flags);

Nit: there'd be two empty lines in between; nicer to drop one.