Re: [PATCH V1 2/2] phy: qcom-qmp-ufs: Add Phy Configuration support for SC7280

From: Konrad Dybcio
Date: Wed Aug 16 2023 - 14:14:25 EST


On 16.08.2023 20:12, Konrad Dybcio wrote:
> On 16.08.2023 17:48, Nitin Rawat wrote:
>> Add SC7280 specific register layout and table configs.
>>
>> Co-developed-by: Manish Pandey <quic_mapa@xxxxxxxxxxx>
>> Signed-off-by: Manish Pandey <quic_mapa@xxxxxxxxxxx>
>> Signed-off-by: Nitin Rawat <quic_nitirawa@xxxxxxxxxxx>
>> ---
> Looks very reasonable compared to what I can see downstream.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
I guess one nit I'd add is that having the compatible list sorted
alphanumerically would be a nice touch

Konrad