Re: [PATCH] nlookup missing decrement in fuse_direntplus_link

From: Miklos Szeredi
Date: Wed Aug 16 2023 - 04:06:11 EST


On Fri, 11 Aug 2023 at 09:12, <ruan.meisi@xxxxxxxxxx> wrote:
>
> From 53aad83672123dbe01bcef9f9026becc4e93ee9f Mon Sep 17 00:00:00 2001
> From: ruanmeisi <ruan.meisi@xxxxxxxxxx>
> Date: Tue, 25 Apr 2023 19:13:54 +0800
> Subject: [PATCH] nlookup missing decrement in fuse_direntplus_link
>
> During our debugging of glusterfs, we found an Assertion
> failed error: inode_lookup >= nlookup, which was caused by the
> nlookup value in the kernel being greater than that in the FUSE
> file system.The issue was introduced by fuse_direntplus_link,
> where in the function, fuse_iget increments nlookup, and if
> d_splice_alias returns failure, fuse_direntplus_link returns
> failure without decrementing nlookup
> https://github.com/gluster/glusterfs/pull/4081
>
> Signed-off-by: ruanmeisi <ruan.meisi@xxxxxxxxxx>

Applied, thanks.

Miklos