Re: [PATCH v1] kernel: Add space before parenthesis and around '=', "==" and '<'

From: Atul Kumar Pant
Date: Tue Aug 15 2023 - 22:56:54 EST


On Tue, Aug 15, 2023 at 06:09:19PM -0400, Paul Moore wrote:
> On Aug 15, 2023 Atul Kumar Pant <atulpant.linux@xxxxxxxxx> wrote:
> >
> > Fixes following checkpatch.pl issue:
> > ERROR: space required before the open parenthesis '('
> > ERROR: spaces required around that '='
> > ERROR: spaces required around that '<'
> > ERROR: spaces required around that '=='
> >
> > Signed-off-by: Atul Kumar Pant <atulpant.linux@xxxxxxxxx>
> > ---
> > kernel/acct.c | 2 +-
> > kernel/auditfilter.c | 16 ++++++++--------
> > kernel/auditsc.c | 2 +-
> > 3 files changed, 10 insertions(+), 10 deletions(-)
>
> I changed the subject line to "audit: add space before parenthesis and
> around '=', "==", and '<'" as the "audit:" prefix is more appropriate
> and I'm a believer of the Oxford Comma. Otherwise it looks fine and I
> just merged it into audit/next, thanks.

Thank you for your comments. Do I need to change commit message now?

>
> --
> paul-moore.com