Re: [PATCH v2] HID: apple: Add "Hailuck" to the list of non-apple keyboards

From: Rahul Rameshbabu
Date: Tue Aug 15 2023 - 22:23:52 EST



On Tue, 15 Aug, 2023 13:19:59 -0700 "Nils Tonnaett" <ntonnatt@xxxxxxxxxxxxxxxxxx> wrote:
> Powzan keyboards KB750 and KB770 identify as
> "Hailuck Co.,Ltd USB Keyboard". Adding "Hailuck" to the list
> of non-apple keyboards fixes function keys for these models.
>
> Signed-off-by: Nils Tonnaett <ntonnatt@xxxxxxxxxxxxxxxxxx>
> ---
> V1 -> V2:
> - Start commit message subject with HID: apple: instead of hid:
> - Comma terminate last member of array
>
> drivers/hid/hid-apple.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
> index d7b932925730..3ca45975c686 100644
> --- a/drivers/hid/hid-apple.c
> +++ b/drivers/hid/hid-apple.c
> @@ -343,7 +343,8 @@ static const struct apple_non_apple_keyboard non_apple_keyboards[] = {
> { "SONiX USB DEVICE" },
> { "Keychron" },
> { "AONE" },
> - { "GANSS" }
> + { "GANSS" },
> + { "Hailuck" },
> };
>
> static bool apple_is_non_apple_keyboard(struct hid_device *hdev)

Reviewed-by: Rahul Rameshbabu <sergeantsagara@xxxxxxxxxxxxxx>