Re: [PATCH 6/8] KVM: gmem, x86: Add gmem hook for invalidating private memory

From: kernel test robot
Date: Tue Aug 15 2023 - 20:44:33 EST


Hi,

kernel test robot noticed the following build errors:

[auto build test ERROR on 89b6a7b873d72280e85976bbb8fe4998b2ababa8]

url: https://github.com/intel-lab-lkp/linux/commits/isaku-yamahata-intel-com/KVM-gmem-Make-kvm_gmem_bind-return-EBADF-on-wrong-fd/20230816-012315
base: 89b6a7b873d72280e85976bbb8fe4998b2ababa8
patch link: https://lore.kernel.org/r/8c9f0470ba6e5dc122f3f4e37c4dcfb6fb97b184.1692119201.git.isaku.yamahata%40intel.com
patch subject: [PATCH 6/8] KVM: gmem, x86: Add gmem hook for invalidating private memory
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230816/202308160801.jwbys3HI-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230816/202308160801.jwbys3HI-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308160801.jwbys3HI-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

arch/x86/kvm/../../../virt/kvm/guest_mem.c: In function 'kvm_gmem_punch_hole':
>> arch/x86/kvm/../../../virt/kvm/guest_mem.c:186:40: error: 'kvm' undeclared (first use in this function)
186 | kvm_gmem_issue_arch_invalidate(kvm, file, start, end);
| ^~~
arch/x86/kvm/../../../virt/kvm/guest_mem.c:186:40: note: each undeclared identifier is reported only once for each function it appears in
>> arch/x86/kvm/../../../virt/kvm/guest_mem.c:186:45: error: 'file' undeclared (first use in this function)
186 | kvm_gmem_issue_arch_invalidate(kvm, file, start, end);
| ^~~~


vim +/kvm +186 arch/x86/kvm/../../../virt/kvm/guest_mem.c

169
170 static long kvm_gmem_punch_hole(struct inode *inode, loff_t offset, loff_t len)
171 {
172 struct list_head *gmem_list = &inode->i_mapping->private_list;
173 pgoff_t start = offset >> PAGE_SHIFT;
174 pgoff_t end = (offset + len) >> PAGE_SHIFT;
175 struct kvm_gmem *gmem;
176
177 /*
178 * Bindings must stable across invalidation to ensure the start+end
179 * are balanced.
180 */
181 filemap_invalidate_lock(inode->i_mapping);
182
183 list_for_each_entry(gmem, gmem_list, entry)
184 kvm_gmem_invalidate_begin(gmem, start, end);
185
> 186 kvm_gmem_issue_arch_invalidate(kvm, file, start, end);
187 truncate_inode_pages_range(inode->i_mapping, offset, offset + len - 1);
188
189 list_for_each_entry(gmem, gmem_list, entry)
190 kvm_gmem_invalidate_end(gmem, start, end);
191
192 filemap_invalidate_unlock(inode->i_mapping);
193
194 return 0;
195 }
196

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki