Re: [PATCH] signal: Fix the error return of kill -1

From: Oleg Nesterov
Date: Tue Aug 15 2023 - 11:14:15 EST


On 08/15, David Laight wrote:
>
> or maybe even:
> } else {
> struct task_struct * p;
> int err;
> ret = -ESRCH;
>
> for_each_process(p) {
> if (task_pid_vnr(p) > 1 &&
> !same_thread_group(p, current)) {
> err = group_send_sig_info(sig, info, p,
> PIDTYPE_MAX);
> if (ret)
> ret = err;

Hmm, indeed ;)

and "err" can be declared inside the loop.

Oleg.