Re: [PATCH v9 05/13] media: cadence: csi2rx: Add get_fmt and set_fmt pad ops

From: Tomi Valkeinen
Date: Tue Aug 15 2023 - 08:06:53 EST


On 11/08/2023 13:47, Jai Luthra wrote:
From: Pratyush Yadav <p.yadav@xxxxxx>

The format is needed to calculate the link speed for the external DPHY
configuration. It is not right to query the format from the source
subdev. Add get_fmt and set_fmt pad operations so that the format can be
configured and correct bpp be selected.

Initialize and use the v4l2 subdev active state to keep track of the
active formats. Also propagate the new format from the sink pad to all
the source pads.

Signed-off-by: Pratyush Yadav <p.yadav@xxxxxx>
Co-authored-by: Jai Luthra <j-luthra@xxxxxx>
Reviewed-by: Maxime Ripard <mripard@xxxxxxxxxx>
Signed-off-by: Jai Luthra <j-luthra@xxxxxx>
---
Changes from v8:
- Squash the patch adding RAW8 and RAW10 formats within this one
- Single line struct entries in formats[] array
- Skip specifiying redundant format.which entry in init_cfg()


Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

Tomi