Re: [PATCH v3 2/2] lib/vsprintf: Declare no_hash_pointers in sprintf.h

From: Petr Mladek
Date: Tue Aug 15 2023 - 06:59:32 EST


On Mon 2023-08-14 19:33:44, Andy Shevchenko wrote:
> Sparse is not happy to see non-static variable without declaration:
> lib/vsprintf.c:61:6: warning: symbol 'no_hash_pointers' was not declared. Should it be static?
>
> Declare respective variable in the sprintf.h. With this, add a comment
> to discourage its use if no real need.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Acked-by: Marco Elver <elver@xxxxxxxxxx>

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr