Re: [PATCH] firmware: cs_dsp: Fix new control name check

From: Richard Fitzgerald
Date: Tue Aug 15 2023 - 05:26:13 EST


On 4/8/23 17:52, Vlad Karpovich wrote:
Before adding a new FW control, its name is checked against
existing controls list. But the string length in strncmp used
to compare controls names is taken from the list, so if beginnings
of the controls are matching, then the new control is not created.
For example, if CAL_R control already exists, CAL_R_SELECTED
is not created.
The fix is to compare string lengths as well.

Fixes: 6477960755fb ("ASoC: wm_adsp: Move check for control existence")
Signed-off-by: Vlad Karpovich <vkarpovi@xxxxxxxxxxxxxxxxxxxxx>
---

You need to send this to Mark Brown.