Re: [PATCH 1/3] mips: remove unneeded #include <asm/export.h>

From: Thomas Bogendoerfer
Date: Tue Aug 15 2023 - 05:11:27 EST


On Tue, Aug 08, 2023 at 12:32:41AM +0900, Masahiro Yamada wrote:
> There is no EXPORT_SYMBOL line there, hence #include <asm/export.h>
> is unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
> arch/mips/kernel/octeon_switch.S | 1 -
> arch/mips/kernel/r2300_switch.S | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/mips/kernel/octeon_switch.S b/arch/mips/kernel/octeon_switch.S
> index 9b7c8ab6f08c..447a3ea14aa1 100644
> --- a/arch/mips/kernel/octeon_switch.S
> +++ b/arch/mips/kernel/octeon_switch.S
> @@ -11,7 +11,6 @@
> * written by Carsten Langgaard, carstenl@xxxxxxxx
> */
> #include <asm/asm.h>
> -#include <asm/export.h>
> #include <asm/asm-offsets.h>
> #include <asm/mipsregs.h>
> #include <asm/regdef.h>
> diff --git a/arch/mips/kernel/r2300_switch.S b/arch/mips/kernel/r2300_switch.S
> index 71b1aafae1bb..48e63943e6f7 100644
> --- a/arch/mips/kernel/r2300_switch.S
> +++ b/arch/mips/kernel/r2300_switch.S
> @@ -13,7 +13,6 @@
> */
> #include <asm/asm.h>
> #include <asm/cachectl.h>
> -#include <asm/export.h>
> #include <asm/fpregdef.h>
> #include <asm/mipsregs.h>
> #include <asm/asm-offsets.h>
> --
> 2.39.2

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]