Re: [PATCH 18/33] iris: vidc: hfi: add Host Firmware Interface (HFI)

From: Dikshita Agarwal
Date: Mon Aug 14 2023 - 15:13:00 EST




On 7/31/2023 2:32 PM, Bryan O'Donoghue wrote:
> On 28/07/2023 14:23, Vikash Garodia wrote:
>> This implements the interface for communication between
>> host driver and firmware through interface commands and messages.
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
>> Signed-off-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>
>
> More dead code here
>
> drivers/media/platform/qcom/iris/vidc/src/venus_hfi.c:542:    //if
> (core->last_packet_type != HFI_CMD_SYS_PC_PREP)
> drivers/media/platform/qcom/iris/vidc/src/venus_hfi.c:543:    //
> core->skip_pc_count = 0;
>
Thanks for pointing it, will remove in next version
> ---
> bod
>