Re: [PATCH v2 3/5] virt: sevguest: Prep for kernel internal {get, get_ext}_report()

From: Dionna Amalie Glaze
Date: Mon Aug 14 2023 - 12:59:47 EST


>
> switch (ioctl) {
> case SNP_GET_REPORT:
> - ret = get_report(snp_dev, &input);
> + ret = get_report(snp_dev, &input, SNP_UARG);
> break;
> case SNP_GET_DERIVED_KEY:
> ret = get_derived_key(snp_dev, &input);
> break;

Do we have an agreement around the continued existence of sev-guest
for supporting derived keys, is that similarly slated for the chopping
block, or is it left undecided?
It appears your choice to not include the uarg/karg extension here is
deliberate.

> case SNP_GET_EXT_REPORT:
> - ret = get_ext_report(snp_dev, &input);
> + ret = get_ext_report(snp_dev, &input, SNP_UARG);
> break;
> default:
> break;
>

Reviewed-by: Dionna Glaze <dionnaglaze@xxxxxxxxxx>

--
-Dionna Glaze, PhD (she/her)