Re: [PATCH v2 0/3] lib/vsprintf: Rework header inclusions

From: Andy Shevchenko
Date: Mon Aug 14 2023 - 12:18:55 EST


On Mon, Aug 14, 2023 at 05:38:17PM +0200, Petr Mladek wrote:
> On Sat 2023-08-05 20:50:24, Andy Shevchenko wrote:
> > Some patches that reduce the mess with the header inclusions related to
> > vsprintf.c module. Each patch has its own description, and has no
> > dependencies to each other, except the collisions over modifications
> > of the same places. Hence the series.
> >
> > Changelog v2:
> > - covered test_printf.c in patches 1 & 2
> > - do not remove likely implict inclusions (Rasmus)
> > - declare no_hash_pointers in sprintf.h (Marco, Steven, Rasmus)
> >
> > Andy Shevchenko (3):
> > lib/vsprintf: Sort headers alphabetically
>
> I am sorry but I am still against this patch?
>
> > lib/vsprintf: Split out sprintf() and friends
> > lib/vsprintf: Declare no_hash_pointers in sprintf.h
>
> I am fine with these two.
>
> Would you mind preparing v3 without the sorting patch, please?

Yes. Thank you for the review.

--
With Best Regards,
Andy Shevchenko