Re: [PATCH] qed: remove unused 'resp_size' calculation

From: Leon Romanovsky
Date: Mon Aug 14 2023 - 06:14:08 EST


On Mon, Aug 14, 2023 at 09:45:03AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> Newer versions of clang warn about this variable being assigned but
> never used:
>
> drivers/net/ethernet/qlogic/qed/qed_vf.c:63:67: error: parameter 'resp_size' set but not used [-Werror,-Wunused-but-set-parameter]
>
> There is no indication in the git history on how this was ever
> meant to be used, so just remove the entire calculation and argument
> passing for it to avoid the warning.
>
> Fixes: 1408cc1fa48c5 ("qed: Introduce VFs")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> drivers/net/ethernet/qlogic/qed/qed_vf.c | 45 +++++++++---------------
> 1 file changed, 17 insertions(+), 28 deletions(-)
>

I don't think that Fixes tag is really needed here and title should be [PATCH
net] or [PATCH net-next].

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>