Re: [PATCH] brcm80211: brcmsmac: phy_cmn: Remove unreachable code

[Jonas Gorski]

On Sun, 13 Aug 2023 at 23:31, Artem Chernyshev
<artem.chernyshev@xxxxxxxxxxx> wrote:
>
> Since wlc_phy_txpwr_srom_read_nphy() in wlc_phy_attach_nphy()
> can not return false it's impossible to get true value in this
> if statement

If they can only return true, then maybe their return types should be
changed to void as well? No point in returning a value when the only
caller is ignoring it.

>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Artem Chernyshev <artem.chernyshev@xxxxxxxxxxx>

Regards,
Jonas