Re: [patch V3 23/40] x86/cpu: Provide cpu_init/parse_topology()

From: Zhang, Rui
Date: Mon Aug 14 2023 - 03:12:36 EST


On Mon, 2023-08-14 at 08:26 +0200, Thomas Gleixner wrote:
> On Sat, Aug 12 2023 at 08:00, Rui Zhang wrote:
> > On Sat, 2023-08-12 at 14:38 +0800, Zhang Rui wrote:
> > BTW, can we consider using system wide unique core_id instead?
> >
> > There are a couple of advantages by using this.
> > CC Len, who can provide detailed justifications for this.
>
> I have no problem with that. But as I said before we need a
> discussion
> about the ID representation in general so it becomes a consistent
> view
> at all levels.

Agreed.
And I think Len will be back online and propose something soon and we
can start with that. :)

>
> The other thing to think about is whether we really need all these
> IDs
> explicitly stored in cpu_info::topo... The vast majority of usage
> sites
> is in some slow path (setup, cpu hotplug, proc, sysfs ...).
>

I don't have a strong preference here. With the new framework, this
info is really handy even if we don't cache it somewhere.

thanks,
rui