Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property

[Conor Dooley]

On Mon, Aug 14, 2023 at 10:43:58AM +0530, Md Danish Anwar wrote:
> On 11/08/23 8:51 pm, Conor Dooley wrote:
> > On Fri, Aug 11, 2023 at 04:48:28PM +0530, Md Danish Anwar wrote:
> > 
> >>>> There are no standard defines for these interrupt types. However I can create a
> >>>> new .h file defining all the three interrupt cells and their values for both
> >>>> PRU and RTU cores if you think that is required. Otherwise we can go with
> >>>> hardcoded values.
> >>>>
> >>>> Please let me know what you think should be done here.
> >>>
> >>> It'd be good to reference to the documentation for the cells, I don't
> >>> think adding a header is necessary here.
> >>>
> >>
> >> How should I reference to the documentation for the cells?
> >>
> >> Should I just add the details of cells in description of interrupt property here.
> >>
> >>   interrupts:
> >>     maxItems: 1
> >>     description:
> >>       Interrupt specifiers enable the virtio/rpmsg communication between MPU
> >>       and the PRU/RTU cores. The value of the interrupts should be the PRU
> >>       System event number [cell 1], PRU channel [cell 2] and PRU host_event
> >>       (target) [cell 3].
> >>
> >> Please let me know if this looks OK to you.
> > 
> > I was thinking there'd be an binding for the interrupt controller that
> > you could mentioned.
> 
> There is a binding for interrupt-controller [1] that I can mention. I tried using
> 
> - $ref: /schemas/interrupt-controller/ti,pruss-intc.yaml#
> 
> But it was throwing dt binding errors so I didn't add the ref.

Yeah, you're not a pruss-itc so that makes sense.

> 
> I will mention this file name in the description of the property like below,
> 
>      description:
>        Interrupt specifiers enable the virtio/rpmsg communication between MPU
>        and the PRU/RTU cores. For the values of the interrupt cells please
>        refer to interrupt-controller/ti,pruss-intc.yaml schema.
> 
> Please let me know if this looks OK to you.

This is what I would've expected, yea

Attachment: signature.asc
Description: PGP signature