Re: [PATCH 1/3] dt-bindings: arm: ti: Add bindings for AM62P5 SoCs

From: Nishanth Menon
Date: Sun Aug 13 2023 - 09:06:35 EST


On 10:55-20230813, Conor Dooley wrote:
> On Thu, Aug 10, 2023 at 01:43:08PM -0500, Nishanth Menon wrote:
> > On 17:03-20230810, Conor Dooley wrote:
> > > On Thu, Aug 10, 2023 at 10:23:12AM +0530, Vignesh Raghavendra wrote:
> > > > From: Bryan Brattlof <bb@xxxxxx>
> > > >
> > > > Add bindings for TI's AM62P5 family of devices.
> > > >
> > > > Signed-off-by: Bryan Brattlof <bb@xxxxxx>
> > > > Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> > > > ---
> > > > Documentation/devicetree/bindings/arm/ti/k3.yaml | 6 ++++++
> > > > 1 file changed, 6 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > > index 5ca6af492507..93b2774cc0a9 100644
> > > > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > > > @@ -25,6 +25,12 @@ properties:
> > > > - ti,am62a7-sk
> > > > - const: ti,am62a7
> > > >
> > > > + - description: K3 AM62P5 SoC
> > >
> > > SoC seems a bit off here, since the sk is actually a board using the
> > > SoC, but it seems to be the convention for TI stuff,
> >
> > Thanks for providing that perspective - there will be new boards
> > getting added to the enum list, they should be one line additions at
> > this point.
> >
> > But, your point taken. K3 AM625P SoC based boards is more appropriate.
> >
> > I can do the local change as I apply and keep your ack unless you
> > object.
>
> Oh totally no objection, "xyz SoC based boards" is what most people seem
> to use.

Thank you V2 addresses it (the version I committed in), but looks like
the k3.yaml can do with a cleanup - will do it in one shot once the
window opens up.

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D