Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings

[Konrad Dybcio]

On 12.08.2023 16:12, Robert Marko wrote:
> On Sat, 12 Aug 2023 at 16:08, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>
>> On 12.08.2023 16:07, Robert Marko wrote:
>>> On Sat, 12 Aug 2023 at 12:47, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>>>
>>>> On 12.08.2023 11:55, Robert Marko wrote:
>>>>> On Sat, 12 Aug 2023 at 00:56, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>>>>>
>>>>>> On 11.08.2023 23:35, Robert Marko wrote:
>>>>>>> On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>>>>>>>>
>>>>>>>> On 11.08.2023 23:01, Robert Marko wrote:
>>>>>>>>> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
>>>>>>>>> as they should be under the partitions subnode and use the generic
>>>>>>>>> jedec,spi-nor compatible.
>>>>>>>>>
>>>>>>>>> Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
>>>>>>>>> ---
>>>>>>>> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"
>>>>>>>
>>>>>>> Hi,
>>>>>>> I grepped the vendor U-Boot to make sure it's not being triggered off
>>>>>>> the mx25l25635e
>>>>>>> compatible but the only hit is the IC support itself.
>>>>>>> MX25L25635 was just the original NOR IC Qualcomm used on the board so
>>>>>>> to me it made
>>>>>>> most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR
>>>>>>> compatible.
>>>>>> OK if dynamic identification works fine
>>>>>
>>>>> It should work fine, datasheet is clear that its JEDEC compatible.
>>>>> That being said, I dont actually have the board, just figured it was
>>>>> time for a cleanup as
>>>>> OpenWrt has been patching DK01 and DK04 for ages.
>>>> Hm. Do we know whether there are still users of this boards?
>>>
>>> I honestly doubt it as they have been broken in OpenWrt for years and
>>> nobody complained.
>>> So we are currently removing support for them, but I still wanted to
>>> at least fixup the DTS state
>>> upstream.
>>> These boards are not obtainable anymore.
>> I also noticed they were detached from the other snapdragons in u-boot
>> for no good reason (at first glance anyway).
> 
> If you are talking about the mainline U-Boot then yeah, my basic port was done
> years ago and I knew way less about the SoC then now.
> Currently its on my TODO to merge them with Snapdragon and add some proper
> GPIO and pinctrl drivers as well as using the Linux DTS.
Take a look at this branch of mine [1], I already did some of that.

If you wish to upstream that, please coordinate with Caleb (+CC) who
may be interested in the same in parallel.

[1] https://github.com/konradybcio/u-boot/commits/konrad/rb1_forcepushing

Konrad