Re: [PATCH v3 1/3] debugfs: Add write support to debugfs_create_str()

From: Greg KH
Date: Sat Aug 12 2023 - 06:36:26 EST


On Fri, Aug 11, 2023 at 10:46:34AM +0300, Georgi Djakov wrote:
> On 7.08.23 17:29, Mike Tipton wrote:
> > Currently, debugfs_create_str() only supports reading strings from
> > debugfs. Add support for writing them as well.
> >
> > Based on original implementation by Peter Zijlstra [0]. Write support
> > was present in the initial patch version, but dropped in v2 due to lack
> > of users. We have a user now, so reintroduce it.
> >
> > [0] https://lore.kernel.org/all/YF3Hv5zXb%2F6lauzs@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> >
>
> Hi Greg,
>
> Looks like the original code was reviewed two years ago (not sure if it
> counts). But in any case, i need an ack from you to apply this.
>
> There is no build dependency with the rest of the patches (but there is a
> functional one). It should be also fine if you apply it directly, if you
> prefer so?

Feel free for this to go with the code that uses it:

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>