Re: [PATCH v2] tracing/eprobe: Iterate trace_eprobe directly

From: Google
Date: Sat Aug 12 2023 - 01:22:36 EST


On Fri, 11 Aug 2023 15:45:23 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Fri, 11 Aug 2023 16:12:39 +0800
> Chuang Wang <nashuiliang@xxxxxxxxx> wrote:
>
> > +
> > +#define for_each_trace_eprobe_on_trace_probe(ep, _tp) \
> > + list_for_each_entry(ep, trace_probe_probe_list(_tp), tp.list)
> > +
>
> As I replied to the other patch, but after this one was sent (sorry, I was
> hyperfocused on my work the last couple of days and was not reading email,
> so my INBOX is a bit full). I really hate the verbosity of that name.
>
> At a minimum, let's call it:
>
> for_each_trace_point_eprobe()

OK, what about "for_each_trace_eprobe_on()"? I would like to clarify

- what type is returned
- not all trace_eprobes, but only on the trace_probe.

Thank you,

>
> -- Steve


--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>