Re: [PATCH 6/7] ARM: dts: qcom: add device tree for Nokia Lumia 735

[Konrad Dybcio]

On 11.08.2023 23:35, Rayyan Ansari wrote:
> Add an initial device tree for the Nokia Lumia 735, codenamed
> "superman-lte".
> 
> Co-authored-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Co-authored-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Co-authored-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> Signed-off-by: Jack Matthews <jm5112356@xxxxxxxxx>
> Signed-off-by: Rayyan Ansari <rayyan@xxxxxxxxx>
> ---
>  arch/arm/boot/dts/qcom/Makefile               |  1 +
>  .../qcom-msm8926-microsoft-superman-lte.dts   | 52 +++++++++++++++++++
>  2 files changed, 53 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
> 
> diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
> index 487e0a5987ce..7982620ec9f9 100644
> --- a/arch/arm/boot/dts/qcom/Makefile
> +++ b/arch/arm/boot/dts/qcom/Makefile
> @@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
>  	qcom-msm8916-samsung-e7.dtb \
>  	qcom-msm8916-samsung-grandmax.dtb \
>  	qcom-msm8916-samsung-serranove.dtb \
> +	qcom-msm8926-microsoft-superman-lte.dtb \
>  	qcom-msm8960-cdp.dtb \
>  	qcom-msm8960-samsung-expressatt.dtb \
>  	qcom-msm8974-lge-nexus5-hammerhead.dtb \
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
> new file mode 100644
> index 000000000000..9e165eddeca7
> --- /dev/null
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8926-microsoft-superman-lte.dts
> @@ -0,0 +1,52 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2023, Jack Matthews <jm5112356@xxxxxxxxx>
> + * Copyright (c) 2023, Ivaylo Ivanov <ivo.ivanov.ivanov1@xxxxxxxxx>
> + * Copyright (c) 2023, Dominik Kobinski <dominikkobinski314@xxxxxxxxx>
> + * Copyright (c) 2023, Rayyan Ansari <rayyan@xxxxxxxxx>
> + */
> +
> +/dts-v1/;
> +
> +#include "qcom-msm8226-microsoft-common.dtsi"
> +
> +/ {
> +	model = "Nokia Lumia 735";
> +	compatible = "microsoft,superman-lte", "qcom,msm8926";
Hm.. maybe "qcom,msm8926", "qcom,msm8226" so that we don't have to add
both to cpufreq_dt blacklist etc

> +	chassis-type = "handset";
> +};
> +
> +&blsp1_i2c3 {
> +	status = "okay";
> +
> +	touchscreen@4b {
> +		compatible = "syna,rmi4-i2c";
> +		reg = <0x4b>;
> +
> +		interrupts-extended = <&tlmm 17 IRQ_TYPE_EDGE_FALLING>;
> +		vdd-supply = <&pm8226_l15>;
> +		vio-supply = <&pm8226_l6>;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&touchscreen_on>;
flip order

> +
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		rmi4-f01@1 {
> +			reg = <0x01>;
> +			syna,nosleep-mode = <1>;
> +		};
> +
> +		rmi4-f11@11 {
> +			reg = <0x11>;
> +			syna,sensor-type = <1>;
> +		};
> +	};
> +};
> +
> +&blsp1_i2c5 {
> +	status = "disabled";
sneaky microsoft

Konrad
> +
> +	/delete-node/ touchscreen@4b;
> +};