Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property

From: Conor Dooley
Date: Fri Aug 11 2023 - 11:22:01 EST


On Fri, Aug 11, 2023 at 04:48:28PM +0530, Md Danish Anwar wrote:

> >> There are no standard defines for these interrupt types. However I can create a
> >> new .h file defining all the three interrupt cells and their values for both
> >> PRU and RTU cores if you think that is required. Otherwise we can go with
> >> hardcoded values.
> >>
> >> Please let me know what you think should be done here.
> >
> > It'd be good to reference to the documentation for the cells, I don't
> > think adding a header is necessary here.
> >
>
> How should I reference to the documentation for the cells?
>
> Should I just add the details of cells in description of interrupt property here.
>
> interrupts:
> maxItems: 1
> description:
> Interrupt specifiers enable the virtio/rpmsg communication between MPU
> and the PRU/RTU cores. The value of the interrupts should be the PRU
> System event number [cell 1], PRU channel [cell 2] and PRU host_event
> (target) [cell 3].
>
> Please let me know if this looks OK to you.

I was thinking there'd be an binding for the interrupt controller that
you could mentioned.

Attachment: signature.asc
Description: PGP signature