Re: [PATCH] thermal: k3_j72xx_bandgap: removed unneeded call to platform_set_drvdata()

[Alexandru Ardelean]

On Thu, Aug 10, 2023 at 2:20 PM Andrei Coardos <aboutphysycs@xxxxxxxxx> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@xxxxxxxxxxx>

> Signed-off-by: Andrei Coardos <aboutphysycs@xxxxxxxxx>
> ---
>  drivers/thermal/k3_j72xx_bandgap.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c
> index 5be1f09eeb2c..b91743dbd95a 100644
> --- a/drivers/thermal/k3_j72xx_bandgap.c
> +++ b/drivers/thermal/k3_j72xx_bandgap.c
> @@ -502,8 +502,6 @@ static int k3_j72xx_bandgap_probe(struct platform_device *pdev)
>         writel(K3_VTM_ANYMAXT_OUTRG_ALERT_EN, data[0].bgp->cfg2_base +
>                K3_VTM_MISC_CTRL_OFFSET);
>
> -       platform_set_drvdata(pdev, bgp);
> -
>         print_look_up_table(dev, ref_table);
>         /*
>          * Now that the derived_table has the appropriate look up values
> --
> 2.34.1
>