RE: [PATCH net-next 1/2] dt-bindings: net: snps,dwmac: Tx queues with coe

From: G Thomas, Rohan
Date: Thu Aug 10 2023 - 13:47:56 EST


Dear Conor,

On Thu, Aug 10, 2023 at 11:03:27PM +0800, Rohan G Thomas wrote:
> > Add dt-bindings for the number of tx queues with coe support. Some
> > dwmac IPs support tx queues only for few initial tx queues, starting
> > from tx queue 0.
> >
> > Signed-off-by: Rohan G Thomas <rohan.g.thomas@xxxxxxxxx>
> > ---
> > Documentation/devicetree/bindings/net/snps,dwmac.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > index ddf9522a5dc2..ad26a32e0557 100644
> > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> > @@ -313,6 +313,9 @@ properties:
> > snps,tx-queues-to-use:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > description: number of TX queues to be used in the driver
> > + snps,tx-queues-with-coe:
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + description: number of TX queues support TX checksum
> > + offloading
>
> Either you omitted a "ing" or a whole word from this description.

Thanks for pointing this out. Will fix it in the next version as below,
description: number of TX queues that supports TX checksum offloading
>
> > snps,tx-sched-wrr:
> > type: boolean
> > description: Weighted Round Robin
> > --
> > 2.26.2
> >

Best Regards,
Rohan