Re: [PATCH 2/4][next] i40e: Replace one-element array with flex-array member in struct i40e_profile_segment

From: Justin Stitt
Date: Thu Aug 10 2023 - 13:34:11 EST


On Tue, Aug 01, 2023 at 11:05:59PM -0600, Gustavo A. R. Silva wrote:
> One-element and zero-length arrays are deprecated. So, replace
> one-element array in struct i40e_profile_segment with flexible-array
> member.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/335
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
> drivers/net/ethernet/intel/i40e/i40e_type.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Justin Stitt <justinstitt@xxxxxxxxxx>

>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> index c3d5fe12059a..f7a984304b65 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> @@ -1487,7 +1487,7 @@ struct i40e_profile_segment {
> struct i40e_ddp_version version;
> char name[I40E_DDP_NAME_SIZE];
> u32 device_table_count;
> - struct i40e_device_id_entry device_table[1];
> + struct i40e_device_id_entry device_table[];
> };
>
> struct i40e_section_table {
> --
> 2.34.1
>