Re: [PATCH v3] pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets

[Linus Walleij]

On Wed, Aug 9, 2023 at 12:09 PM Ninad Naik <quic_ninanaik@xxxxxxxxxxx> wrote:

> SA8775 and newer target have added support for an increased number of
> interrupt targets. To implement this change, the intr_target field, which
> is used to configure the interrupt target in the interrupt configuration
> register is increased from 3 bits to 4 bits.
>
> In accordance to these updates, a new intr_target_width member is
> introduced in msm_pingroup structure. This member stores the value of
> width of intr_target field in the interrupt configuration register. This
> value is used to dynamically calculate and generate mask for setting the
> intr_target field. By default, this mask is set to 3 bit wide, to ensure
> backward compatibility with the older targets.
>
> Fixes: 4b6b18559927 ("pinctrl: qcom: add the tlmm driver sa8775p platforms")
>
> Tested-by: Andrew Halaney <ahalaney@xxxxxxxxxx> # sa8775p-ride
> Signed-off-by: Ninad Naik <quic_ninanaik@xxxxxxxxxxx>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> Reviewed-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx>

Patch applied for fixes!

Yours,
Linus Walleij