Re: [PATCH v5 2/2] gpio: ds4520: Add ADI DS4520 GPIO Expander Support

From: Linus Walleij
Date: Thu Aug 10 2023 - 04:45:32 EST


On Wed, Aug 9, 2023 at 9:19 AM Michael Walle <mwalle@xxxxxxxxxx> wrote:
> > On Thu, Jul 27, 2023 at 11:55=E2=80=AFAM Okan Sahin <okan.sahin@xxxxxxxxxx>=
> > wrote:
> >
> >> The DS4520 is a 9-bit nonvolatile (NV) I/O expander.
> >> It offers users a digitally programmable alternative
> >> to hardware jumpers and mechanical switches that are
> >> being used to control digital logic node.
> >>
> >> Signed-off-by: Okan Sahin <okan.sahin@xxxxxxxxxx>
> >
> > Too late to add review tags but just pointing out what a beauty
> > this driver is when using regmap GPIO. Total success!
>
> Mh somehow I'm always missing consumers of regmap GPIO.
>
> Linus, Bartosz, what do you think about the patch below?
(...)
> +K: (devm_)?gpio_regmap_(un)?register

I never saw that globbing trick before, but makes perfect sense so:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij