Re: [PATCH 1/2] tick: Rename tick_do_update_jiffies64() and allow external usage
From: kernel test robot
Date: Thu Aug 10 2023 - 01:38:15 EST
Hi Huacai,
kernel test robot noticed the following build errors:
[auto build test ERROR on paulmck-rcu/dev]
[also build test ERROR on linus/master v6.5-rc5 next-20230809]
[cannot apply to tip/timers/nohz]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Huacai-Chen/rcu-Update-jiffies-in-rcu_cpu_stall_reset/20230810-121637
base: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev
patch link: https://lore.kernel.org/r/20230810041347.3386770-1-chenhuacai%40loongson.cn
patch subject: [PATCH 1/2] tick: Rename tick_do_update_jiffies64() and allow external usage
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230810/202308101358.qLx84pmx-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308101358.qLx84pmx-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308101358.qLx84pmx-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
kernel/time/tick-sched.c: In function 'tick_sched_do_timer':
>> kernel/time/tick-sched.c:114:25: error: implicit declaration of function 'tick_do_update_jiffies64'; did you mean 'do_update_jiffies_64'? [-Werror=implicit-function-declaration]
114 | tick_do_update_jiffies64(now);
| ^~~~~~~~~~~~~~~~~~~~~~~~
| do_update_jiffies_64
cc1: some warnings being treated as errors
vim +114 kernel/time/tick-sched.c
5bb962269c29cb Frederic Weisbecker 2012-10-15 100
5bb962269c29cb Frederic Weisbecker 2012-10-15 101 /* Check, if the jiffies need an update */
5bb962269c29cb Frederic Weisbecker 2012-10-15 102 if (tick_do_timer_cpu == cpu)
d0936236a70918 Huacai Chen 2023-08-10 103 do_update_jiffies_64(now);
ff7de6203131e3 Rafael J. Wysocki 2018-04-06 104
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 105 /*
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 106 * If jiffies update stalled for too long (timekeeper in stop_machine()
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 107 * or VMEXIT'ed for several msecs), force an update.
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 108 */
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 109 if (ts->last_tick_jiffies != jiffies) {
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 110 ts->stalled_jiffies = 0;
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 111 ts->last_tick_jiffies = READ_ONCE(jiffies);
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 112 } else {
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 113 if (++ts->stalled_jiffies == MAX_STALLED_JIFFIES) {
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 @114 tick_do_update_jiffies64(now);
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 115 ts->stalled_jiffies = 0;
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 116 ts->last_tick_jiffies = READ_ONCE(jiffies);
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 117 }
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 118 }
a1ff03cd6fb9c5 Frederic Weisbecker 2022-02-02 119
ff7de6203131e3 Rafael J. Wysocki 2018-04-06 120 if (ts->inidle)
ff7de6203131e3 Rafael J. Wysocki 2018-04-06 121 ts->got_idle_tick = 1;
5bb962269c29cb Frederic Weisbecker 2012-10-15 122 }
5bb962269c29cb Frederic Weisbecker 2012-10-15 123
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki